Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TGAReader): add vtkTGAReader #3160

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat(TGAReader): add vtkTGAReader #3160

merged 1 commit into from
Nov 6, 2024

Conversation

daker
Copy link
Collaborator

@daker daker commented Oct 29, 2024

Context

This PR adds support for TGA format
Fixes #3155

Results

Enregistrement.de.l.ecran.2024-10-29.170120.mp4

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@finetjul finetjul added module: I/O type: feature request 💡 Desired capabilities / enhancements labels Oct 29, 2024
finetjul
finetjul approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Nov 6, 2024
Merged via the queue into Kitware:master with commit 644df60 Nov 6, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 32.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 6, 2024
@daker daker deleted the tga-reader branch November 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst left review comments

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
module: I/O released Automated label type: feature request 💡 Desired capabilities / enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support for TGA images
3 participants
@daker @finetjul @floryst